----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32630/#review78225 -----------------------------------------------------------
+1. I'd really like if we could at least try to introduce a tool to detect this, but definitely not a blocker. - Cody Maloney On March 30, 2015, 5:47 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32630/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 5:47 p.m.) > > > Review request for mesos, Benjamin Hindman and switched to 'mcypark'. > > > Repository: mesos > > > Description > ------- > > Ben suggested we start pushing proposal markdowns to the repo, so they can go > through a nice review process. > This proposal is to augment the style guide to disallow capturing temporaries > by reference. > > > Diffs > ----- > > docs/proposals/style/const_ref_to_temporary.md PRE-CREATION > > Diff: https://reviews.apache.org/r/32630/diff/ > > > Testing > ------- > > The 'output' in the proposal shows the problem. > > > Thanks, > > Joris Van Remoortere > >