----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32654/#review78283 -----------------------------------------------------------
src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32654/#comment126807> Please rename this to "hostIPNetwork". We don't need the leading underscore anymore. src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32654/#comment126809> Looks like this is not needed anymore. src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32654/#comment126811> I would rather keep the type `IP` for `hostIP`. ``` hostIP = hostIPNetwork.get().address(); ``` src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32654/#comment126814> s/string/net::IP/ Since we don't have a default constructor of IP, you probabaly want to initilize it to INADDR_ANY. src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32654/#comment126815> This fits in one line. Please do a sweep to fix similar issues. - Jie Yu On March 30, 2015, 11:29 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32654/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 11:29 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, and Cong Wang. > > > Bugs: mesos-2332 > https://issues.apache.org/jira/browse/mesos-2332 > > > Repository: mesos > > > Description > ------- > > Clean up HostIPNetwork since every use performs the same extract & stringify > operation > > > Diffs > ----- > > src/tests/port_mapping_tests.cpp 8192deac8d9b7ea1896bb62a8b5961ef90326fa4 > > Diff: https://reviews.apache.org/r/32654/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Paul Brett > >
