----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32742/#review78618 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/32742/#comment127535> Could you just use "\n" since that's what we're joining with? src/slave/slave.cpp <https://reviews.apache.org/r/32742/#comment127534> Is this a bit more succinct? ``` foreach (pid_t pid, processes.get()) { Result<os::Process> process = os::process(pid); if (process.isSome()) { infos.push_back(stringify(pid) + " '" + process.get().command + "'"); } else { infos.push_back(stringify(pid)); } } ``` - Ben Mahler On April 1, 2015, 10:39 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32742/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 10:39 p.m.) > > > Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. > > > Bugs: MESOS-2461 > https://issues.apache.org/jira/browse/MESOS-2461 > > > Repository: mesos > > > Description > ------- > > Added command logging for processes running in slave's cgroup. > > > Diffs > ----- > > src/slave/slave.cpp 0f70ebafb0f5b16c560decc66e22a43a52732d09 > > Diff: https://reviews.apache.org/r/32742/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
