----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32744/#review78669 -----------------------------------------------------------
Ship it! This looks great! Just some nits! src/slave/containerizer/isolators/network/port_mapping.hpp <https://reviews.apache.org/r/32744/#comment127581> Please put the `NOTE` in a new line. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/32744/#comment127585> Kill this new line and add a new line above the `NOTE`. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/32744/#comment127586> indent here should be 4 spaces. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/32744/#comment127587> s/containerIDs/container IDs/ Here and everywhere else. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/32744/#comment127588> Please print a warning here? ``` LOG(WARNING) << "Detected non-symlink '" << path << "' under bind mount symlink root '" << PORT_MAPPING_BIND_MOUNT_SYMLINK_ROOT() << "'. Ignoring it"; ``` Then, you don't need the comments above. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/32744/#comment127590> Indent should be 4 spaces here. src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/32744/#comment127591> Ditto. - Jie Yu On April 1, 2015, 10:36 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32744/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 10:36 p.m.) > > > Review request for mesos, Jie Yu and Cong Wang. > > > Bugs: mesos-2574 > https://issues.apache.org/jira/browse/mesos-2574 > > > Repository: mesos > > > Description > ------- > > MESOS-2574 > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.hpp > 33837b4662959a003c8f38d1e786c6615287a4ff > src/slave/containerizer/isolators/network/port_mapping.cpp > e691d463515084518c94cdec3fbdf37be4a72977 > src/tests/port_mapping_tests.cpp f4124c3e880e043729579a829e1057727741d131 > > Diff: https://reviews.apache.org/r/32744/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
