----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32798/#review78783 -----------------------------------------------------------
Ship it! src/tests/docker_containerizer_tests.cpp <https://reviews.apache.org/r/32798/#comment127812> My only question here is how do you know the executor is properly killed and cleaned up? Is this because you know there aren't any more child processes? Is that something you want to check after you call Shutdown()? I.e., os::children(0).get().empty() or something like that? - Benjamin Hindman On April 2, 2015, 11:38 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32798/ > ----------------------------------------------------------- > > (Updated April 2, 2015, 11:38 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-2583 > https://issues.apache.org/jira/browse/MESOS-2583 > > > Repository: mesos > > > Description > ------- > > Add test to verify executor clean up in docker containerizer. > > > Diffs > ----- > > src/tests/docker_containerizer_tests.cpp > fdd706a892ee1c8d55a406b3f956d99c076c623b > > Diff: https://reviews.apache.org/r/32798/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
