----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32797/#review78785 -----------------------------------------------------------
Ship it! I had another thought after my first review, see below please! src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/32797/#comment127813> Why kill the executor before doing Docker::stop? Can you comment here why you do it in this order versus the other order and the ramifications that has? - Benjamin Hindman On April 2, 2015, 11:38 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32797/ > ----------------------------------------------------------- > > (Updated April 2, 2015, 11:38 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-2583 > https://issues.apache.org/jira/browse/MESOS-2583 > > > Repository: mesos > > > Description > ------- > > Kill the executor when docker container is destroyed. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp b7bf54ac65d6c61622e485ac253513eaac2e4f88 > src/slave/containerizer/docker.cpp e83b912c707a3f2687b09a647a9ed248a940ea97 > > Diff: https://reviews.apache.org/r/32797/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
