----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32820/#review78829 -----------------------------------------------------------
Ship it! Feel free to split out the proces namespace change. src/linux/perf.cpp <https://reviews.apache.org/r/32820/#comment127885> char[] Also noticed many of our other constants are not "static", we may want to do a sweep? - Ben Mahler On April 3, 2015, 5:01 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32820/ > ----------------------------------------------------------- > > (Updated April 3, 2015, 5:01 p.m.) > > > Review request for mesos, Ben Mahler and Ian Downes. > > > Repository: mesos > > > Description > ------- > > Fixed the non-POD global variable in perf sampler. > > > Diffs > ----- > > src/linux/perf.cpp cad6c80e2a9608ff02fc2b8976efba52713dd5a8 > > Diff: https://reviews.apache.org/r/32820/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
