> On March 31, 2015, 11:38 p.m., Ben Mahler wrote: > > Can we punt on version for the initial HTTP API beta release? I say this > > because: > > > > (1) The protobuf objects seems like the wrong place to place a version. If > > a backwards-incompatible change occurs, we may not be able to parse the > > 'Call' or 'Event' anymore! Seems more like the protocol should be versioned > > (e.g. request path, http headers, etc). > > > > (2) AFAICT, we're not doing anything that precludes adding versioning as we > > continue the work on the HTTP API? It just seems like API versioning is a > > substantial project in its own right and requires quite a bit of thought > > that we don't necessarily have the time for now (e.g. what numbers are we > > putting in here? what do they mean? what do we do when we make a backwards > > incompatible change? how will we keep N and N-1 protobuf definitions > > available for support?). Seems like one place where we can reduce scope.
Good point. I'm discarding this review too and punt on versioning for now. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32508/#review78433 ----------------------------------------------------------- On March 31, 2015, 11:17 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32508/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 11:17 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1127 > https://issues.apache.org/jira/browse/MESOS-1127 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 783a63ad1cc0edd86605d638046fb959cb6e97e8 > src/examples/low_level_scheduler_libprocess.cpp > 63d34eefb60d13fe2b82905c1cec9b762340e997 > src/examples/low_level_scheduler_pthread.cpp > 6d1f938660c02db75bfcbf7c8de0d941cff1920d > src/sched/sched.cpp 66fd2b3146568900356cc48e0f17c6720665ae80 > src/tests/scheduler_tests.cpp 4a89a7a88b50bb8c254f5076661ce07ac9fc7657 > > Diff: https://reviews.apache.org/r/32508/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
