----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32898/#review79055 -----------------------------------------------------------
Can you please split this into two separate reviews, one for the ec2 scripts and one for the rest of the codebase. ec2/deploy.amazon64-old/root/mesos-ec2/setup <https://reviews.apache.org/r/32898/#comment128095> This is a strange usage of echo or printf. If we insist on this technique to approve keys, what about using /usr/bin/true? src/tests/port_mapping_tests.cpp <https://reviews.apache.org/r/32898/#comment128098> The argument doesn't need to be quoted if there's no formatting required? Regardless, should stay consistent with double quotes used elsewhere? - Ian Downes On April 6, 2015, 12:27 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32898/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 12:27 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: mesos-1424 > https://issues.apache.org/jira/browse/mesos-1424 > > > Repository: mesos > > > Description > ------- > > Eliminate use of 'echo -n' > > > Diffs > ----- > > ec2/deploy.amazon64-old/root/mesos-ec2/hypertable/Capfile > 8b50912745977cb71232ba1dfa77f8bb0d60191e > ec2/deploy.amazon64-old/root/mesos-ec2/setup > 8d4f4b07c4b6bdf92c66db109930b1c285e7c783 > ec2/deploy.amazon64/root/mesos-ec2/hypertable/Capfile > 8b50912745977cb71232ba1dfa77f8bb0d60191e > ec2/deploy.amazon64/root/mesos-ec2/setup > b6b736091d4d5be431c8da29cdb98360a1df2d29 > ec2/deploy.centos64/root/mesos-ec2/hypertable/Capfile > f85584af5580ecfe5ee5ce3f03fb78408b466ccd > ec2/deploy.centos64/root/mesos-ec2/setup > f380f7a1c29034b795d4ed5197e52effabb5a175 > ec2/deploy.lucid64/root/mesos-ec2/setup > 0a74757433521cfe4b37b0e13221375558dce118 > src/tests/port_mapping_tests.cpp 55a5e69ed818fd0856179026e3deb889236fea77 > support/timed_tests.sh 5e01af9411d1d736b12a6996c3ecb0f18468faca > > Diff: https://reviews.apache.org/r/32898/diff/ > > > Testing > ------- > > make check (on linux host only) > > > Thanks, > > Paul Brett > >
