----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32586/#review79147 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/32586/#comment128282> Const ref of a temporary? src/tests/mesos.cpp <https://reviews.apache.org/r/32586/#comment128283> Why this change? - Adam B On April 1, 2015, 12:35 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32586/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 12:35 p.m.) > > > Review request for mesos, Adam B and Niklas Nielsen. > > > Bugs: MESOS-2557 > https://issues.apache.org/jira/browse/MESOS-2557 > > > Repository: mesos > > > Description > ------- > > The incoming FrameworkInfo has a valid FrameworkID. > > > Diffs > ----- > > src/slave/slave.hpp 19e6b44bc344c0ca509674803f401cbb4e1f47ae > src/slave/slave.cpp c7e65a6c095963feaa9d5fdbb519c68f8f761d16 > src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8 > src/tests/mesos.cpp 11e88330dd50913ab00da79054225d113541e83e > src/tests/slave_tests.cpp fd09d65bf34136c0959419b451e54105300740c4 > > Diff: https://reviews.apache.org/r/32586/diff/ > > > Testing > ------- > > make check > > TODO: Test for upgrade path. > > > Thanks, > > Kapil Arya > >
