> On April 2, 2015, 7:59 p.m., Vinod Kone wrote: > > src/master/allocator/mesos/allocator.hpp, line 47 > > <https://reviews.apache.org/r/31265/diff/6/?file=912110#file912110line47> > > > > Do you still want the constructor public?
I think there is no reason to hide the c-tor. I can imagine somebody creating an instance on the stack and do not see why we should forbid it. Same approach is used for example for `MesosContainerizer`. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31265/#review78711 ----------------------------------------------------------- On April 1, 2015, 2:28 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31265/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 2:28 p.m.) > > > Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. > > > Bugs: MESOS-2160 > https://issues.apache.org/jira/browse/MESOS-2160 > > > Repository: mesos > > > Description > ------- > > The factory creates allocator instances in a way identical to how instances > from modules are created. It allows us to use same typed tests for built-in > and modularized allocators. > > > Diffs > ----- > > src/master/allocator/mesos/allocator.hpp > fb898f1175b61b442204e6e38c69ccc2838a646f > src/tests/master_allocator_tests.cpp > 03a1bb8c92b44bc1ad1b5f5cff8d1fb971df2302 > > Diff: https://reviews.apache.org/r/31265/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.5, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
