> On April 6, 2015, 7:22 p.m., Benjamin Hindman wrote: > > src/slave/slave.cpp, line 4164 > > <https://reviews.apache.org/r/32911/diff/1/?file=918555#file918555line4164> > > > > Great comment! Can we also add something to the end of the comment that > > says that the user is validated when the task goes through the master? > > Thanks!
Are you referring to when authentication and ACL's are enabled? > On April 6, 2015, 7:22 p.m., Benjamin Hindman wrote: > > src/slave/slave.cpp, line 4166 > > <https://reviews.apache.org/r/32911/diff/1/?file=918555#file918555line4166> > > > > Why don't you need to check the taskInfo? Is it because we should have > > set the executorInfo's 'user' appropriately? If so, let's comment as much, > > even going as far as introducing a CHECK! I don't follow; the user may not be set on the task.command.user or task.executor.command.user? It isn't ensured to be set by the master? - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32911/#review79113 ----------------------------------------------------------- On April 6, 2015, 5:40 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32911/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 5:40 p.m.) > > > Review request for mesos, Benjamin Hindman and Ian Downes. > > > Bugs: MESOS-2592 > https://issues.apache.org/jira/browse/MESOS-2592 > > > Repository: mesos > > > Description > ------- > > During recent refactorings, executor directory ownership was delegated to the > fetcher. However, the fetcher is not invoked if no URIs are present in the > executor or task command. This left some of these tasks broken as the > directory ownership defaulted to the mesos-slave's (root). > > > Diffs > ----- > > src/slave/containerizer/external_containerizer.cpp > 1bbd61cb096771b7e4a1350079f79a20102e78f9 > src/slave/paths.hpp 1618439d728ded347ec75317ce8dd998acd7ee94 > src/slave/paths.cpp 01ea856aa2e628d4aee5fd31f7e49d147f740e8f > src/slave/slave.cpp 521624c335b9110e12ee1ff21c3918e5af6a2bde > > Diff: https://reviews.apache.org/r/32911/diff/ > > > Testing > ------- > > Functional tests with mesos-execute and make check. Have created JIRA's for > introduction of more permission/user tests. > > > Thanks, > > Niklas Nielsen > >
