----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32756/#review79390 -----------------------------------------------------------
src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/32756/#comment128688> Ditto. src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/32756/#comment128689> Is it a problem of keeping up, or just that it's an asychronous process that periodically/as required marks pages? src/tests/memory_test_helper.hpp <https://reviews.apache.org/r/32756/#comment128697> How does this tie into the timing loop above in the test? Do we know within what time the kernel will mark pages inactive? src/tests/memory_test_helper.hpp <https://reviews.apache.org/r/32756/#comment128696> s/requestAndNoWait/requestWithoutWait? src/tests/memory_test_helper.cpp <https://reviews.apache.org/r/32756/#comment128695> Write the memory buffer with different values to ensure the compiler cannot optimize away this block. src/tests/memory_test_helper.cpp <https://reviews.apache.org/r/32756/#comment128694> TODO on a new line. - Ian Downes On April 1, 2015, 4:17 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32756/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 4:17 p.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Bugs: mesos-2572 > https://issues.apache.org/jira/browse/mesos-2572 > > > Repository: mesos > > > Description > ------- > > Added a memory statistics test for active anonymous memory. > > > Diffs > ----- > > src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef > src/tests/memory_test_helper.hpp 11712d7f378d9426f160d53b0387c698a28a4207 > src/tests/memory_test_helper.cpp cdf769b32036c746ec4aa90841ea45c9a4159b51 > > Diff: https://reviews.apache.org/r/32756/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
