----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32757/#review79394 -----------------------------------------------------------
src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/32757/#comment128698> Can you please make this change to the first review of this chain. src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/32757/#comment128699> This code is in every test, consider pushing it into the SetUp()? src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/32757/#comment128700> Please comment on why we need this loop. src/tests/memory_test_helper.cpp <https://reviews.apache.org/r/32757/#comment128702> What happens to this test if /tmp is a tmpfs? src/tests/memory_test_helper.cpp <https://reviews.apache.org/r/32757/#comment128701> Why is the read necessary? - Ian Downes On April 1, 2015, 4:18 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32757/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 4:18 p.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Bugs: mesos-2572 > https://issues.apache.org/jira/browse/mesos-2572 > > > Repository: mesos > > > Description > ------- > > Added a memory statistics test for writeback. > > > Diffs > ----- > > src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef > src/tests/memory_test_helper.hpp 11712d7f378d9426f160d53b0387c698a28a4207 > src/tests/memory_test_helper.cpp cdf769b32036c746ec4aa90841ea45c9a4159b51 > > Diff: https://reviews.apache.org/r/32757/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
