-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32955/#review79400
-----------------------------------------------------------

Ship it!



src/tests/cgroups_tests.cpp
<https://reviews.apache.org/r/32955/#comment128710>

    Not yours, but isn't 512 overkill :-) if the limit is 64 then anything >= 
64 MB should trigger it? How about actually tying it to the limit, e.g., 
2*limit?


- Ian Downes


On April 7, 2015, 7:29 p.m., Chi Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32955/
> -----------------------------------------------------------
> 
> (Updated April 7, 2015, 7:29 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Bugs: mesos-2573
>     https://issues.apache.org/jira/browse/mesos-2573
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Simplified ROOT_CGROUPS_Listen test.
> 
> 
> Diffs
> -----
> 
>   src/tests/cgroups_tests.cpp e18aed1feca182da89a117f81bed0897a00fb0ef 
> 
> Diff: https://reviews.apache.org/r/32955/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Reply via email to