----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32998/#review79457 -----------------------------------------------------------
Thanks for doing this! I know most of this was just splitting the file, but I thought here/now would be a good place/time to add additional comments/feedback on the docs. docs/committing.md <https://reviews.apache.org/r/32998/#comment128850> Also make sure that the patch author gets credited as such in the commit. Automatically handled by apply-review.sh, but worth mentioning in case you have to make any minor changes or rebase. docs/committing.md <https://reviews.apache.org/r/32998/#comment128849> Would like to formalize what kinds of changes you "don't worry about going through a review cycle". I'd propose that typo/comment/doc changes under 5 lines, or obvious build fixes are immune. Anything more complex than that deserves at least a cursory review. docs/effective-code-reviewing.md <https://reviews.apache.org/r/32998/#comment128852> Keep in mind that the review Summary + Description gets used as the commit message, so don't put unnecessary fluff in there. The testing message doesn't go into the commit section, so it can be used for notes to the reviewers. Also, please provide details about the testing done and new tests added; hopefully more than just `make check`. docs/effective-code-reviewing.md <https://reviews.apache.org/r/32998/#comment128854> s/scope of the work be reduced/scope of the work should be reduced/ - Adam B On April 8, 2015, 5:30 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32998/ > ----------------------------------------------------------- > > (Updated April 8, 2015, 5:30 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Niklas Nielsen, > and Vinod Kone. > > > Bugs: MESOS-2581 > https://issues.apache.org/jira/browse/MESOS-2581 > > > Repository: mesos > > > Description > ------- > > "Committer's Guide" was too generic. This names the documents after "what" > the reader is looking for: doing effective reviews, and how to commit changes > (for committers only). > > > Diffs > ----- > > docs/committers-guide.md c016ee9cb3290d7788ed258904547b59bbea4f11 > docs/committing.md PRE-CREATION > docs/effective-code-reviewing.md PRE-CREATION > docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea > > Diff: https://reviews.apache.org/r/32998/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Ben Mahler > >
