> On April 8, 2015, 1:13 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, line 2048 > > <https://reviews.apache.org/r/32939/diff/1/?file=920067#file920067line2048> > > > > While you're here, how about: > > > > ``` > > VLOG(2) << "Dropping event for process: " << to; > > ``` > > > > If you want to get a bit fancier, we could pull up JSONVisitor and use > > it to print what we're dropping, but I doubt that be of much value right > > now. > > Ben Mahler wrote: > s/:// since ':' usually precedes a reason for the issue.
I'd be wary of sharing the message data, since that could potentially contain secrets which shouldn't be shared. ProcessIDs on the other hand are always safe to print / already always available. - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32939/#review79288 ----------------------------------------------------------- On April 7, 2015, 9:48 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32939/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 9:48 p.m.) > > > Review request for mesos, Ben Mahler and Cody Maloney. > > > Repository: mesos > > > Description > ------- > > Currently these log messages are fired whenever we have delayed messages to a > process that is exited (e.g., log appends). I've also seen this a bunch in > our tests. Bumping this to VLOG(2) to keep fidelity of VLOG(1) high. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > cf4e36489be2c6aa01e838c1c71383f248deab5b > > Diff: https://reviews.apache.org/r/32939/diff/ > > > Testing > ------- > > > Thanks, > > Vinod Kone > >
