> On April 13, 2015, 10:20 p.m., Till Toenshoff wrote: > > configure.ac, line 579 > > <https://reviews.apache.org/r/32749/diff/2/?file=926378#file926378line579> > > > > This is a bit unusual. We haven't marked our branches that way so far > > but I kinda like it.
Mesos does actually do something similar for #ifdef / #endif header include guards as well as namespaces, although those are both in a little different format. - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32749/#review79954 ----------------------------------------------------------- On April 13, 2015, 9:01 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32749/ > ----------------------------------------------------------- > > (Updated April 13, 2015, 9:01 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-2550 > https://issues.apache.org/jira/browse/MESOS-2550 > > > Repository: mesos > > > Description > ------- > > Add -Wno-unused-local-typedef for clang 3.6 > > > Diffs > ----- > > configure.ac 868c0413a2e2307ae8ab2211f56874595759b139 > > Diff: https://reviews.apache.org/r/32749/diff/ > > > Testing > ------- > > For series: > > ../configure --disable-java --disable-python CC=clang CXX=clang++ > `make check` passed on ArchLinux with clang version 3.6 as host compiler. > CXXFLAGS contains the typedef. Didn't build without patches. > `make check` on ArchLinux with GCC 4.9 > > ../configure > `make distcheck` on CentOS 7 (GCC 4.8) > > ../configure > `make distcheck` with OS X (Clang 3.5). Verified no > '-Wno-unused-local-typedef'. > > > Thanks, > > Cody Maloney > >
