----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31665/ -----------------------------------------------------------
(Updated April 17, 2015, 5:31 a.m.) Review request for mesos, Alexander Rukletsov and Ben Mahler. Changes ------- (1) `s/usedResources/totalUsedResources/` (2) `s/offeredResources/totalOfferedResources/` (3) `s/usedResourcesBySlaveId/usedResources/` (4) `s/offeredResourcesBySlaveId/offeredResources/` (5) Added a `NOTE` regarding why keeping totals is safe followed by a `TODO` to address [MESOS-2623](https://issues.apache.org/jira/browse/MESOS-2373). (6) Added a `TODO` for the call to `allocator->addFramework` for what needs to be done in the next step. Bugs: MESOS-2373 https://issues.apache.org/jira/browse/MESOS-2373 Repository: mesos Description ------- `master::Framework` holds 2 member variables of type `Resources`: `usedResources` and `offeredResources`. Both of these are aggregates of resources from multiple slaves. We add the `hashmap<SlaveID, Resources>` versions since we can lose non-scalar resources by summing them up across multiple slaves. For further details refer to [MESOS-2373](https://issues.apache.org/jira/browse/MESOS-2373). In [r31666](https://reviews.apache.org/r/31666/), we report `usedResourcesBySlaveId` rather than `usedResources` when adding the framework to the allocator. We don't actually use `offeredResourcesBySlaveId` currently, but it should be kept for symmetry. There will be a ticket to expose `usedResourcesBySlaveId` as well as `offeredResourcesBySlaveId` via the HTTP endpoint. Diffs (updated) ----- src/master/http.cpp f2b123d7f84eafc792849ad4630c2e3b63be000b src/master/master.hpp 4a1df58e6756bff7d5f292c0542023a9215e33d8 src/master/master.cpp 02f35ac2d98d288bf9d2b9195770b839bbfe6d7a Diff: https://reviews.apache.org/r/31665/diff/ Testing ------- make check Thanks, Michael Park
