----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33174/#review80595 -----------------------------------------------------------
src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/33174/#comment130681> The pid here is the executor pid, which is not the docker container pid, so setting cgroup on the command executor doesn't buy you much. src/slave/containerizer/docker.cpp <https://reviews.apache.org/r/33174/#comment130682> We shouldn't need to call update right after for cfs, and also this seems like it's going to write to cfs cgroup every update, which seems wrong too. If we want to set up this we should have a patch in launch that is only responsible for setting cfs if it's configured. - Timothy Chen On April 14, 2015, 8:32 p.m., Steve Niemitz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33174/ > ----------------------------------------------------------- > > (Updated April 14, 2015, 8:32 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-2617 > https://issues.apache.org/jira/browse/MESOS-2617 > > > Repository: mesos > > > Description > ------- > > Fix for docker containerizer not configuring CFS quotas correctly. > > It would be nice to refactor all this isolation code in a way that can be > shared between all containerizers, as this is basically just copied from the > CgroupsCpushareIsolator, but that's a much bigger undertaking. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 5f4b4ce49a9523e4743e5c79da4050e6f9e29ed7 > > Diff: https://reviews.apache.org/r/33174/diff/ > > > Testing > ------- > > > Thanks, > > Steve Niemitz > >
