> On April 8, 2015, 5:31 p.m., Adam B wrote: > > src/examples/test_hook_module.cpp, line 36 > > <https://reviews.apache.org/r/30961/diff/7/?file=920371#file920371line36> > > > > Unused? Or should you check that the value being removed is what you > > expect? > > Niklas Nielsen wrote: > It was just to keep the module and test code in sync. Would you prefer I > remove it?
Yeah, when it comes to variables and constants, I say use it or lose it. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30961/#review79454 ----------------------------------------------------------- On April 7, 2015, 5:57 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30961/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 5:57 p.m.) > > > Review request for mesos, Ben Mahler and Kapil Arya. > > > Bugs: MESOS-2351 > https://issues.apache.org/jira/browse/MESOS-2351 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/hook.hpp 9ae8b9455a86c7a5cbf4f1d1b1ce88f2811ce35d > src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41 > src/hook/manager.cpp 7a4cb09bc221af502e867cfb7fff2900b599ff1f > src/master/master.cpp 618db68ee4163b06e479cf3413eda4b63c9c5a4b > src/tests/hook_tests.cpp bb9de25bd2c4601d333a3ca1aec13820c7df7378 > > Diff: https://reviews.apache.org/r/30961/diff/ > > > Testing > ------- > > make check (with modified VerifyMasterLaunchTaskHook test) > > > Thanks, > > Niklas Nielsen > >
