----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33356/#review80744 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On April 20, 2015, 1:44 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33356/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 1:44 p.m.) > > > Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. > > > Bugs: MESO-2160 > https://issues.apache.org/jira/browse/MESO-2160 > > > Repository: mesos > > > Description > ------- > > Since the Allocator is a public interface now, there is no reason to keep > RoleInfo in mesos.internal. It is ok to change the package because RoleInfo > is used solely by Master and Allocator, hence there is no external > communication affected. > > NOTE: It looks like ReviewBoard can't get it right again, please check the > diff directly. > > > Diffs > ----- > > include/mesos/master/allocator.hpp bb40b1c7d62131b8f3af040aedfc6be4c8590a26 > include/mesos/master/allocator.proto PRE-CREATION > src/master/allocator/mesos/allocator.hpp > af27a9bd8299cbff01e04b74db47c86bf247b908 > src/master/allocator/mesos/hierarchical.hpp > 90ac19736fbd56847db925cb497c4e3d9070af0a > src/master/master.hpp c10e7c08c191acef9d31d98018a47a2a952a4dfc > src/master/master.cpp e30b951eda2b3b0d5b2a80716f0b32c6bbe041bc > src/tests/hierarchical_allocator_tests.cpp > 0b564a74d3f04df46fe52fcbe1bf8d4d1e41c53c > src/tests/mesos.hpp 7744df55a2a31446327da7bd2b16457e90711d22 > > Diff: https://reviews.apache.org/r/33356/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.5, CentOS 7.0) > > > Thanks, > > Alexander Rukletsov > >
