> On April 11, 2015, 3:26 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 1186-1188 > > <https://reviews.apache.org/r/31016/diff/4/?file=920381#file920381line1186> > > > > What makes this the ideal place to do the label decoration? Looks like > > this is wedged between setting up different unschedule calls. Seems like we > > should either decorate the labels as early as possible, right after (or > > before?) the pid/id/state checks; or, if we need to delay it, we could do > > it after the unschedules. > > Niklas Nielsen wrote: > Great point - I will probably move it up before the unschedule code. Does > that sound OK to you? > > Adam B wrote: > Yeah, I'm thinking earlier is better, so we don't early-exit without > updating labels.
Took that for a spin and we need the framework info, so we need to have it after the unschedule block :/ - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31016/#review79803 ----------------------------------------------------------- On April 11, 2015, 3:03 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31016/ > ----------------------------------------------------------- > > (Updated April 11, 2015, 3:03 a.m.) > > > Review request for mesos, Ben Mahler and Kapil Arya. > > > Bugs: MESOS-2351 > https://issues.apache.org/jira/browse/MESOS-2351 > > > Repository: mesos > > > Description > ------- > > Added decorator which gets invoked on start of runTask() sequence in the > slave. > > > Diffs > ----- > > include/mesos/hook.hpp 9ae8b9455a86c7a5cbf4f1d1b1ce88f2811ce35d > src/hook/manager.hpp da813492108974a7e26b366845368517589da876 > src/hook/manager.cpp 7a4cb09bc221af502e867cfb7fff2900b599ff1f > src/slave/slave.hpp 19e6b44bc344c0ca509674803f401cbb4e1f47ae > src/slave/slave.cpp 9fec023b643d410f4d511fa6f80e9835bab95b7e > > Diff: https://reviews.apache.org/r/31016/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
