----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32948/#review80826 -----------------------------------------------------------
Ship it! Looks good. Just a couple of minor reorderings and a WillRepeatedly to fix. Fix it, then Ship It! src/tests/hook_tests.cpp <https://reviews.apache.org/r/32948/#comment130933> registered() should be called before resourceOffers(), so let's set up the expectations in that order. src/tests/hook_tests.cpp <https://reviews.apache.org/r/32948/#comment130935> .WillOnce(FutureArg<1>(&status)) .WillRepeatedly(Return()); // ignore future updates src/tests/hook_tests.cpp <https://reviews.apache.org/r/32948/#comment130937> This should happen before the exec.registered, exec.launchTask, and sched.statusUpdate, so let's set up the expectation/future before them. - Adam B On April 20, 2015, 1:17 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32948/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 1:17 p.m.) > > > Review request for mesos, Adam B and Kapil Arya. > > > Bugs: MESOS-2351 > https://issues.apache.org/jira/browse/MESOS-2351 > > > Repository: mesos > > > Description > ------- > > See summary > > > Diffs > ----- > > src/tests/hook_tests.cpp bb9de25bd2c4601d333a3ca1aec13820c7df7378 > > Diff: https://reviews.apache.org/r/32948/diff/ > > > Testing > ------- > > make check (test broke previously with an assert as the TestContainerizer > cannot be used with a command executor) > > > Thanks, > > Niklas Nielsen > >
