> On Jan. 18, 2015, 12:18 p.m., Bernd Mathiske wrote: > > src/slave/containerizer/docker.cpp, line 615 > > <https://reviews.apache.org/r/29334/diff/5/?file=824297#file824297line615> > > > > Here one can see that we are dealing with a more general graph than a > > series. How can one know why ___launch (3 underscores) is not needed in > > this branch? > > > > And how can one know what ___launch, ____launch, _____launch do in the > > first place? One must read them all, memorize them, and then read this > > stretch of code again. Ideas?
We can talk about what we like this to be, and I'd like to avoid general renaming and flow changes in this patch, we can file another JIRA if we need changes to make things more clear. > On Jan. 18, 2015, 12:18 p.m., Bernd Mathiske wrote: > > src/slave/containerizer/docker.cpp, line 784 > > <https://reviews.apache.org/r/29334/diff/5/?file=824297#file824297line784> > > > > "mesos-docker-executor" comes out of nowhere. Declaring it as a > > constant (possibly, but not necessarily in this file) would provide a > > natural way to link to background information (e.g. what exactly this > > program does and where to find it). This info could then be found trivially > > by looking up said declaration, where one would place some explanations. As it's only referenced here, I'll just leave comment around it for now. > On Jan. 18, 2015, 12:18 p.m., Bernd Mathiske wrote: > > src/slave/containerizer/docker.cpp, line 982 > > <https://reviews.apache.org/r/29334/diff/5/?file=824297#file824297line982> > > > > Not checking the outcome of this? This is actually reverted in the last patch I have, so please ignore this. > On Jan. 18, 2015, 12:18 p.m., Bernd Mathiske wrote: > > src/slave/containerizer/docker.cpp, line 1421 > > <https://reviews.apache.org/r/29334/diff/5/?file=824297#file824297line1421> > > > > not -> not have > > on -> in > > has -> had been > > executor -> executors This is no longer relevant in the my latest patch in this seris, please ignore. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29334/#review68559 ----------------------------------------------------------- On April 7, 2015, 12:46 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29334/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 12:46 a.m.) > > > Review request for mesos, Benjamin Hindman and Bernd Mathiske. > > > Bugs: MESOS-2183 > https://issues.apache.org/jira/browse/MESOS-2183 > > > Repository: mesos > > > Description > ------- > > Add option to launch docker containers with helper containers. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp b7bf54a > src/slave/containerizer/docker.cpp 5f4b4ce > > Diff: https://reviews.apache.org/r/29334/diff/ > > > Testing > ------- > > make, tests are fixed in next commit > > > Thanks, > > Timothy Chen > >
