----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33249/#review80915 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/33249/#comment131094> std::string is already imported. And we usually spell out the whole words instead of abbreviations (errorMessage). src/slave/slave.cpp <https://reviews.apache.org/r/33249/#comment131095> mesos namespace should been imported? src/tests/slave_tests.cpp <https://reviews.apache.org/r/33249/#comment131105> You don't need a mock executor right? src/tests/slave_tests.cpp <https://reviews.apache.org/r/33249/#comment131100> Much better! src/tests/slave_tests.cpp <https://reviews.apache.org/r/33249/#comment131099> Just one empty line. src/tests/slave_tests.cpp <https://reviews.apache.org/r/33249/#comment131104> I don't think this is necessary? src/tests/slave_tests.cpp <https://reviews.apache.org/r/33249/#comment131101> one line src/tests/slave_tests.cpp <https://reviews.apache.org/r/33249/#comment131102> What's this for? - Timothy Chen On April 20, 2015, 10:43 p.m., Jay Buffington wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33249/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 10:43 p.m.) > > > Review request for mesos, Ben Mahler, Timothy Chen, and Vinod Kone. > > > Bugs: MESOS-2020 > https://issues.apache.org/jira/browse/MESOS-2020 > > > Repository: mesos > > > Description > ------- > > When mesos is unable to launch the containerizer the scheduler should > get a TASK_FAILED with a status message that includes the error the > containerizer encounted when trying to launch. > > Introduces a new TaskStatus: REASON_CONTAINERIZER_LAUNCH_FAILED > > Fixes MESOS-2020 > > > Diffs > ----- > > include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537 > src/slave/slave.cpp 8ec80ed26f338690e0a1e712065750ab77a724cd > src/tests/slave_tests.cpp b826000e0a4221690f956ea51f49ad4c99d5e188 > > Diff: https://reviews.apache.org/r/33249/diff/ > > > Testing > ------- > > I added test case to slave_test.cpp. I also tried this with Aurora, supplied > a bogus docker image url and saw the "docker pull" failure stderr message in > Aurora's web UI. > > > Thanks, > > Jay Buffington > >
