> On April 21, 2015, 4:25 p.m., Evelina Dumitrescu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 200 > > <https://reviews.apache.org/r/33329/diff/2/?file=935586#file935586line200> > > > > I wanted to say to keep the freeaddrinfo and initialize result with NULL
I see. I think if this interface returns an error, it should guarantee that dynamic memory has not been allocated. (I am fine with keeping freeaddrinfo, but I feel that'd be dead code) - Chi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33329/#review80984 ----------------------------------------------------------- On April 20, 2015, 7:16 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33329/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 7:16 p.m.) > > > Review request for mesos, Ben Mahler, Evelina Dumitrescu, and Jie Yu. > > > Bugs: mesos-2636 > https://issues.apache.org/jira/browse/mesos-2636 > > > Repository: mesos > > > Description > ------- > > Removed unnecessary freeaddrinfo in getIP if getaddrinfo returns error. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > 3622165af064a1f0a9d461af0e1d0d88a352d4a8 > > Diff: https://reviews.apache.org/r/33329/diff/ > > > Testing > ------- > > > Thanks, > > Chi Zhang > >
