Thanks for the fix Jie!

Tim

On Fri, Apr 24, 2015 at 2:38 PM, Jie Yu <[email protected]> wrote:
> Tim's patch cause a few compiler warnings. I committed a fix (just added to
> the spreadsheet).
>
> On Fri, Apr 24, 2015 at 2:35 PM, Jie Yu <[email protected]> wrote:
>
>> Now that MESOS-2601 has landed, shall we include it in 0.22.1(-rc5) too?
>>
>>
>> +1
>>
>> On Fri, Apr 24, 2015 at 2:34 PM, Adam Bordelon <[email protected]> wrote:
>>
>>> Added MESOS-2643 to the cherry-pick spreadsheet
>>> <https://docs.google.com/a/mesosphere.io/spreadsheets/d/1OzAWNjAL4zKtI-jOJqaQUcDNlnrNik2Dd7dHhwFLKcI/edit#gid=0>
>>> .
>>>
>>> Now that MESOS-2601 has landed, shall we include it in 0.22.1(-rc5) too?
>>>
>>> On Wed, Apr 22, 2015 at 2:58 PM, Benjamin Mahler <
>>> [email protected]> wrote:
>>>
>>>> Linked it with the release ticket as a blocker.
>>>>
>>>> The fix is committed.
>>>>
>>>> On Wed, Apr 22, 2015 at 2:53 PM, Benjamin Mahler <[email protected]>
>>>> wrote:
>>>>
>>>> > One regression in 0.22.x we missed:
>>>> > https://issues.apache.org/jira/browse/MESOS-2643
>>>> >
>>>> > Here, the python bindings are not backwards compatible in that they
>>>> > disable implicit acknowledgements by default. The fix is trivial, and I
>>>> > have a review linked below. Can we get this in 0.22.1?
>>>> >
>>>> > https://reviews.apache.org/r/33452/
>>>> >
>>>> > On Tue, Apr 14, 2015 at 11:26 PM, Timothy Chen <[email protected]>
>>>> wrote:
>>>> >
>>>> >> I also think we should push that fix for 0.23.0, it will take time to
>>>> >> review and merge.
>>>> >>
>>>> >> Tim
>>>> >>
>>>> >> On Tue, Apr 14, 2015 at 10:17 PM, Benjamin Hindman
>>>> >> <[email protected]> wrote:
>>>> >> > Yes, fixing it in 0.23.0 SGTM.
>>>> >> >
>>>> >> > On Tue, Apr 14, 2015 at 10:02 PM, Jie Yu <[email protected]>
>>>> wrote:
>>>> >> >
>>>> >> >> I am just asking if you guys want to fix that for 0.22.1 or not. It
>>>> >> sounds
>>>> >> >> to me a non trivial fix. Given the bug is there for quite a while,
>>>> >> maybe we
>>>> >> >> can fix it in 0.23.0?
>>>> >> >>
>>>> >> >> - Jie
>>>> >> >>
>>>> >> >> On Tue, Apr 14, 2015 at 9:55 PM, Benjamin Hindman <
>>>> >> [email protected]>
>>>> >> >> wrote:
>>>> >> >>
>>>> >> >> > We are going to include MESOS-2614 (it's a really trivial fix).
>>>> >> >> >
>>>> >> >> > Jie, where did you get MESOS-2601 from? That's definitely not in
>>>> the
>>>> >> >> > spreadsheet.
>>>> >> >> >
>>>> >> >> > On Tue, Apr 14, 2015 at 7:40 PM, Jie Yu <[email protected]>
>>>> wrote:
>>>> >> >> >
>>>> >> >> > > Also, this one:
>>>> >> >> > > https://issues.apache.org/jira/browse/MESOS-2601
>>>> >> >> > >
>>>> >> >> > > This sounds like a non trivial fix.
>>>> >> >> > >
>>>> >> >> > > - Jie
>>>> >> >> > >
>>>> >> >> > > On Tue, Apr 14, 2015 at 6:35 PM, Benjamin Mahler <
>>>> >> >> > > [email protected]>
>>>> >> >> > > wrote:
>>>> >> >> > >
>>>> >> >> > > >  Per Nik's comment here:
>>>> >> >> > > >
>>>> >> >> > > > Based on input from Vinod and Adam; I will reduce the scope
>>>> on
>>>> >> the
>>>> >> >> > point
>>>> >> >> > > > > release to focus on MESOS-1795 and MESOS-2583.
>>>> >> >> > > > > I will move the other tickets back to 0.23.0 if you don't
>>>> have
>>>> >> any
>>>> >> >> > > > > objections - let me know if you have any tickets which were
>>>> >> >> > regressions
>>>> >> >> > > > in
>>>> >> >> > > > > 0.22.0.
>>>> >> >> > > >
>>>> >> >> > > >
>>>> >> >> > > > I expected there to be fewer tickets in the spreadsheet, are
>>>> the
>>>> >> >> extra
>>>> >> >> > > > tickets (e.g.
>>>> https://issues.apache.org/jira/browse/MESOS-2614)
>>>> >> >> going
>>>> >> >> > to
>>>> >> >> > > > be
>>>> >> >> > > > included after all?
>>>> >> >> > > >
>>>> >> >> > > > On Tue, Apr 14, 2015 at 6:20 PM, Joris Van Remoortere <
>>>> >> >> > > [email protected]
>>>> >> >> > > > >
>>>> >> >> > > > wrote:
>>>> >> >> > > >
>>>> >> >> > > > > I think the plan is to cut a new RC by sometime tomorrow.
>>>> The
>>>> >> >> > > spreadsheet
>>>> >> >> > > > > is up-to-date, just need to cherry-pick and modify the
>>>> >> change-log.
>>>> >> >> > > > >
>>>> >> >> > > > > Joris
>>>> >> >> > > > >
>>>> >> >> > > > > On Tue, Apr 14, 2015 at 5:37 PM, Benjamin Mahler <
>>>> >> >> > > > > [email protected]>
>>>> >> >> > > > > wrote:
>>>> >> >> > > > >
>>>> >> >> > > > > > Hey Nik, any progress on this? Is the spreadsheet
>>>> up-to-date?
>>>> >> >> > > > > >
>>>> >> >> > > > > > On Wed, Apr 8, 2015 at 1:00 AM, Adam Bordelon <
>>>> >> >> [email protected]>
>>>> >> >> > > > > wrote:
>>>> >> >> > > > > >
>>>> >> >> > > > > > > Hi Adam,
>>>> >> >> > > > > > >
>>>> >> >> > > > > > > Yes, once we have finalized the scope of the point
>>>> release,
>>>> >> >> > Niklas
>>>> >> >> > > > will
>>>> >> >> > > > > > > send out an announcement of Mesos 0.22.1-rc1 (release
>>>> >> >> candidate)
>>>> >> >> > > > which
>>>> >> >> > > > > we
>>>> >> >> > > > > > > would love you to test any way you can. The email will
>>>> >> contain
>>>> >> >> > > > > > instructions
>>>> >> >> > > > > > > for building the release candidate and voting in the
>>>> >> thread.
>>>> >> >> See
>>>> >> >> > > the
>>>> >> >> > > > > vote
>>>> >> >> > > > > > > thread from 0.22.0-rc4 (became final):
>>>> >> >> > > > > > >
>>>> >> >> http://www.mail-archive.com/dev%40mesos.apache.org/msg30668.html
>>>> >> >> > > > > > >
>>>> >> >> > > > > > > The current thread is to collect suggestions for bug
>>>> fixes
>>>> >> to
>>>> >> >> > > include
>>>> >> >> > > > > in
>>>> >> >> > > > > > > this point release.
>>>> >> >> > > > > > >
>>>> >> >> > > > > > > Cheers,
>>>> >> >> > > > > > > -Adam-
>>>> >> >> > > > > > >
>>>> >> >> > > > > > > On Tue, Apr 7, 2015 at 9:22 AM, Adam Avilla <
>>>> [email protected]>
>>>> >> >> > wrote:
>>>> >> >> > > > > > >
>>>> >> >> > > > > > > > On Fri, Apr 3, 2015 at 3:47 PM, Niklas Nielsen <
>>>> >> >> > > > [email protected]
>>>> >> >> > > > > >
>>>> >> >> > > > > > > > wrote:
>>>> >> >> > > > > > > >
>>>> >> >> > > > > > > > > Based on input from Vinod and Adam; I will reduce
>>>> the
>>>> >> scope
>>>> >> >> > on
>>>> >> >> > > > the
>>>> >> >> > > > > > > point
>>>> >> >> > > > > > > > > release to focus on MESOS-1795 and MESOS-2583.
>>>> >> >> > > > > > > > >
>>>> >> >> > > > > > > >
>>>> >> >> > > > > > > > Can I help test these in any way?
>>>> >> >> > > > > > > >
>>>> >> >> > > > > > > > --
>>>> >> >> > > > > > > > /adam
>>>> >> >> > > > > > > >
>>>> >> >> > > > > > >
>>>> >> >> > > > > >
>>>> >> >> > > > >
>>>> >> >> > > >
>>>> >> >> > >
>>>> >> >> >
>>>> >> >>
>>>> >>
>>>> >
>>>> >
>>>>
>>>
>>>
>>

Reply via email to