Hi I have raised review for the code changes:
https://issues.apache.org/jira/browse/MESOS-3187 https://reviews.apache.org/r/37114/ - A second version updated based on the feedback. As per contribution documentation, the review has to be marked as “ship it” before it can be committed. I was wondering, if somebody could help me (Shepherd) here? Thanks On 8/3/15, 10:25 AM, "Vinod Kone" <[email protected]> wrote: >Added you to the contributors. > >On Mon, Aug 3, 2015 at 9:47 AM, Khanduja, Vaibhav ><[email protected]> >wrote: > >> Hi Peter, >> >> Thanks for your reply. >> >> The change for docker daemon options is probably has to be in slave code >> and not int the framework. Other than marathon, there could be other >> framework requiring such support. >> >> The slave during bootup checks for connection, by querying the version >>of >> docker daemon. >> >> I have opened an issue, and plan to work on it: >> https://issues.apache.org/jira/browse/MESOS-3187 >> >> I am not part of contributors list, so cannot assign to myself. Can >> somebody do this for me? I made few changes to code to get this working. >> The changes are now in a pull request: >> >> https://github.com/apache/mesos/pull/53 >> >> I am aware of contribution requirements: >> http://mesos.apache.org/documentation/latest/, and would work in >>creating >> patch if I get the bug assigned. >> >> — VK, >> >> Technologist, >> EMC OCTO >> >> Thx >> >> On 8/3/15, 6:39 AM, "Peter Kolloch" <[email protected]> wrote: >> >> >Hi Vaibhav, >> > >> >the "parameters" option works for parameters of the docker run command: >> > >> > >> >>https://mesosphere.github.io/marathon/docs/native-docker.html#privileged- >>m >> >ode-and-arbitrary-docker-options >> > >> >You tried to use it with a command line argument for the docker >>_daemon_. >> >Starting the docker daemon with the right command line arguments is >>out of >> >scope for Marathon. >> > >> >If you find a parameter of the "docker run" command that works for you, >> >you >> >need to specify the long name for this option (the none-one-letter >>option) >> >in the "parameters" option. >> > >> >If you find the Marathon documentation lacking, we would love to get a >>PR >> >for a documentation improvement from you! >> > >> >See >> > >> >https://mesosphere.github.io/marathon/docs/contributing.html >> > >> >for details. >> > >> >Best regards, >> >Peter >> > >> >[BTW: The Marathon mailing list might be better suited for this kind of >> >question.] >> > >> >On Sat, Aug 1, 2015 at 1:57 AM, Khanduja, Vaibhav >> ><[email protected]> >> >wrote: >> > >> >> Hi >> >> >> >> Having not received any answer, I support there is no solution for >>this. >> >> >> >> The mesos slave process, along with accepting other docker arguments >> >> should somehow manage to take these extra arguments too. I have >>logged >> >> this as an enhancement, and wondering if somebody can look at this: >> >> >> >> https://issues.apache.org/jira/browse/MESOS-3187 >> >> >> >> I am available to provide the fix, if somebody can be a help as >>sheperd. >> >> >> >> Thx >> >> >> >> On 7/30/15, 12:58 PM, "Khanduja, Vaibhav" <[email protected]> >> >> wrote: >> >> >> >> >Hi >> >> > >> >> >jfyi, >> >> > >> >> >I have tried parameter option in marathon json file Š >> >> > >> >> >Š.. >> >> >"parameters": { >> >> > "key": "H", "value": "unix:///var/run/mydocker.sock" >> >> > } >> >> >Š. >> >> > >> >> > >> >> > >> >> > >> >> >On 7/30/15, 12:29 PM, "Khanduja, Vaibhav" <[email protected]> >> >> >wrote: >> >> > >> >> >>Hi >> >> >> >> >> >>I have a use-case where docker deamon does not run on original >>socket >> >> >>path which is /var/run/docker.sock but to a path as given by user. >> I >> >> >>start my docker daemon with H option, >> >> >> >> >> >>docker d H unix:///var/run/mydocker.sock >> >> >> >> >> >>all my docker calls now use this H for e.g. to print images: >> >> >> >> >> >>docker H unix:///var/run/mydocker.sock images >> >> >> >> >> >>I am using Marathon and have started my slave with Docker as >>container >> >> >>option. >> >> >> >> >> >>I cannot see an option in slave, where I can specify the socket >>port >> >>for >> >> >>the it talk with Docker daemon. docker_socket option is used for >> >> >>specifying docker port mapping in the container slave. >> >> >> >> >> >>Does this require code change in slave? >> >> >> >> >> >>Thx >> >> > >> >> >> >> >> >>
