Hi Vaibhav, Yes let's move the conversation over JIRA and IRC, we don't have to involve the whole dev list for this.
Tim On Fri, Sep 4, 2015 at 11:07 AM, Vaibhav Khanduja <vaibhavkhand...@gmail.com> wrote: > Hi Tim > > Thanks you very much. > > I see a place in docker/executor.cpp & launch/executor.cpp where a sleep is > added to wait till the message is received by slave. The length of sleep is > based on an assumption that time is good enough and not waiting for > acknowledgement. Am I looking at the right place? More details on the > issue would help me my analysis? > > Please also let me know if it is preferred to have such communication over > jira. > > Thanks > > On Fri, Sep 4, 2015 at 10:01 AM, Timothy Chen <tnac...@gmail.com> wrote: > >> I can shepherd you on this one. >> >> Tim >> >> On Fri, Sep 4, 2015 at 10:00 AM, Vaibhav Khanduja >> <vaibhavkhand...@gmail.com> wrote: >> > Hi >> > >> > I am looking at issue: https://issues.apache.org/jira/browse/MESOS-2863 >> > marked as newbie. I would like to work on it and was wondering if >> somebody >> > could Shepherd me on this? I believe code being talked here is the sleep >> > in executor for e.g. in docker/executor.cpp - >> > // A hack for now ... but we need to wait until the status >> update >> > >> > // is sent to the slave before we shut ourselves down. >> > >> > // TODO(tnachen): Remove this hack and also the same hack in >> the >> > >> > // command executor when we have the new HTTP APIs to wait >> until >> > >> > // an ack. >> > >> > os::sleep(Seconds(1)); >> > >> > Thanks >>
