PS: The fix is already in master branch (bfeb070a2aef52f445eb057076d344fd184eb461), just need to cherry-pick it into RC2.
On Wed, Oct 7, 2015 at 7:25 PM, Kapil Arya <ka...@mesosphere.io> wrote: > -1 (non-binding) > > Compilation fails on OpenSUSE Tumbleweed (Linux 4.1.6, gcc 5.1.1, glibc > 2.22) with the following errors: > [Created Issue: https://issues.apache.org/jira/browse/MESOS-3603] > > > In file included from ../../src/tests/values_tests.cpp:22:0: > ../3rdparty/libprocess/3rdparty/gmock-1.7.0/gtest/include/gtest/gtest.h: > In instantiatio > n of ‘testing::AssertionResult testing::internal::CmpHelperEQ(const char*, > const char*, > const T1&, const T2&) [with T1 = int; T2 = long unsigned int]’: > ../3rdparty/libprocess/3rdparty/gmock-1.7.0/gtest/include/gtest/gtest.h:1484:23: > requi > red from ‘static testing::AssertionResult > testing::internal::EqHelper<lhs_is_null_litera > l>::Compare(const char*, const char*, const T1&, const T2&) [with T1 = > int; T2 = long un > signed int; bool lhs_is_null_literal = false]’ > ../../src/tests/values_tests.cpp:287:3: required from here > ../3rdparty/libprocess/3rdparty/gmock-1.7.0/gtest/include/gtest/gtest.h:1448:16: > error: > comparison between signed and unsigned integer expressions > [-Werror=sign-compare] > if (expected == actual) { > ^ > CXX tests/containerizer/mesos_tests-provisioner_docker_tests.o > ^CMakefile:6779: recipe for target 'tests/mesos_tests-values_tests.o' > failed > make[3]: *** [tests/mesos_tests-values_tests.o] Interrupt > > =========== > > System details: > > $ uname -a > Linux thinkpad 4.1.6-3-desktop #1 SMP PREEMPT Fri Aug 28 10:59:34 UTC 2015 > (d867e86) x86_64 x86_64 x86_64 GNU/Linux > > $ gcc --version > gcc (SUSE Linux) 5.1.1 20150713 [gcc-5-branch revision 225736] > Copyright (C) 2015 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. There is NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > > $ /lib64/libc.so.6 > GNU C Library (GNU libc) stable release version 2.22 (git bbab82c25da9), > by Roland McGrath et al. > Copyright (C) 2015 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. > There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A > PARTICULAR PURPOSE. > Configured for x86_64-suse-linux. > Compiled by GNU CC version 5.1.1 20150713 [gcc-5-branch revision 225736]. > Available extensions: > crypt add-on version 2.1 by Michael Glad and others > GNU Libidn by Simon Josefsson > Native POSIX Threads Library by Ulrich Drepper et al > BIND-8.2.3-T5B > libc ABIs: UNIQUE IFUNC > For bug reporting instructions, please see: > <http://bugs.opensuse.org>. > > $ cat /etc/SuSE-release > openSUSE 20150909 (x86_64) > VERSION = 20150909 > CODENAME = Tumbleweed > # /etc/SuSE-release is deprecated and will be removed in the future, use > /etc/os-release instead > > > > On Wed, Oct 7, 2015 at 6:14 PM, Greg Mann <g...@mesosphere.io> wrote: > >> Successfully built `sudo make distcheck` on CentOS 7.1 and Ubuntu 14.04 >> with only expected test failures. On our Fedora 22 CI build, however, >> while >> the tests are building the following compile-time error is produced: >> >> [17:18:46][Step 4/6] CXX >> tests/containerizer/mesos_tests-composing_containerizer_tests.o >> >> [17:18:48][Step 4/6] In file included from >> ../../../src/tests/values_tests.cpp:22:0: >> >> [17:18:48][Step 4/6] >> ../3rdparty/libprocess/3rdparty/gmock-1.7.0/gtest/include/gtest/gtest.h: >> In >> instantiation of ‘testing::AssertionResult >> testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const >> T2&) [with T1 = int; T2 = long unsigned int]’: >> >> [17:18:48][Step 4/6] >> >> ../3rdparty/libprocess/3rdparty/gmock-1.7.0/gtest/include/gtest/gtest.h:1484:23: >> required from ‘static testing::AssertionResult >> testing::internal::EqHelper<lhs_is_null_literal>::Compare(const char*, >> const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int; >> bool lhs_is_null_literal = false]’ >> >> [17:18:48][Step 4/6] ../../../src/tests/values_tests.cpp:149:3: required >> from here >> >> [17:18:48][Step 4/6] >> >> ../3rdparty/libprocess/3rdparty/gmock-1.7.0/gtest/include/gtest/gtest.h:1448:16: >> error: comparison between signed and unsigned integer expressions >> [-Werror=sign-compare] >> >> [17:18:48][Step 4/6] if (expected == actual) { >> >> [17:18:48][Step 4/6] ^ >> >> >> Cherry-picking one commit (bfeb070a2aef52f445e "Fixed compiler warning in >> values test.") resolves this issue. >> >> >> >> On Wed, Oct 7, 2015 at 2:32 AM, Joris Van Remoortere <jo...@mesosphere.io >> > >> wrote: >> >> > +1 (binding) >> > >> > On Mon, Oct 5, 2015 at 11:12 PM, Niklas Nielsen <nik...@mesosphere.io> >> > wrote: >> > >> >> Hi all, >> >> >> >> Please vote on releasing the following candidate as Apache Mesos >> 0.25.0. >> >> >> >> >> >> >> >> 0.25.0 includes the following: >> >> >> >> >> >> >> -------------------------------------------------------------------------------- >> >> >> >> * [MESOS-1474] - Experimental support for maintenance primitives. >> >> >> >> * [MESOS-2600] - Added master endpoints /reserve and /unreserve for >> >> dynamic reservations. >> >> >> >> * [MESOS-2044] - Extended Module APIs to enable IP per container >> >> assignment, isolation and resolution. >> >> >> >> >> >> ** Bug fixes >> >> >> >> * [MESOS-2635] - Web UI Display Bug when starting lots of tasks with >> >> small cpu value. >> >> >> >> * [MESOS-2986] - Docker version output is not compatible with Mesos. >> >> >> >> * [MESOS-3046] - Stout's UUID re-seeds a new random generator during >> >> each call to UUID::random. >> >> >> >> * [MESOS-3051] - performance issues with port ranges comparison. >> >> >> >> * [MESOS-3052] - Allocator performance issue when using a large >> number >> >> of filters. >> >> >> >> * [MESOS-3136] - COMMAND health checks with Marathon 0.10.0 are >> broken. >> >> >> >> * [MESOS-3169] - FrameworkInfo should only be updated if the >> >> re-registration is valid. >> >> >> >> * [MESOS-3185] - Refactor Subprocess logic in linux/perf.cpp to use >> >> common subroutine. >> >> >> >> * [MESOS-3239] - Refactor master HTTP endpoints help messages such >> that >> >> they cannot be out of sync. >> >> >> >> * [MESOS-3245] - The comments of DRFSorter::dirty is not correct. >> >> >> >> * [MESOS-3254] - Cgroup CHECK fails test harness. >> >> >> >> * [MESOS-3258] - Remove Frameworkinfo capabilities on >> re-registration. >> >> >> >> * [MESOS-3261] - Move QoS plug-ins to a specified folder like >> >> resource_estimator. >> >> >> >> * [MESOS-3269] - The comments of Master::updateSlave() is not >> correct. >> >> >> >> * [MESOS-3282] - Web UI no longer shows Tasks information. >> >> >> >> * [MESOS-3344] - Add more comments for strings::internal::fmt. >> >> >> >> * [MESOS-3351] - duplicated slave id in master after master failover. >> >> >> >> * [MESOS-3387] - Refactor MesosContainerizer to accept namespace >> >> dynamically. >> >> >> >> * [MESOS-3408] - Labels field of FrameworkInfo should be added into >> v1 >> >> mesos.proto. >> >> >> >> * [MESOS-3411] - ReservationEndpointsTest.AvailableResources appears >> to >> >> be faulty. >> >> >> >> * [MESOS-3423] - Perf event isolator stops performing sampling if a >> >> single timeout occurs. >> >> >> >> * [MESOS-3426] - process::collect and process::await do not perform >> >> discard propagation. >> >> >> >> * [MESOS-3430] - >> >> LinuxFilesystemIsolatorTest.ROOT_PersistentVolumeWithoutRootFilesystem >> >> fails on CentOS 7.1. >> >> >> >> * [MESOS-3450] - Update Mesos C++ Style Guide for namespace usage. >> >> >> >> * [MESOS-3451] - Failing tests after changes to >> >> Isolator/MesosContainerizer API. >> >> >> >> * [MESOS-3458] - Segfault when accepting or declining inverse offers. >> >> >> >> * [MESOS-3474] - ExamplesTest.{TestFramework, JavaFramework, >> >> PythonFramework} failed on CentOS 6. >> >> >> >> * [MESOS-3489] - Add support for exposing Accept/Decline responses >> for >> >> inverse offers. >> >> >> >> * [MESOS-3490] - Mesos UI fails to represent JSON entities. >> >> >> >> * [MESOS-3512] - Don't retry close() on EINTR. >> >> >> >> * [MESOS-3513] - Cgroups Test Filters aborts tests on Centos 6.6. >> >> >> >> * [MESOS-3519] - Fix file descriptor leakage / double close in the >> code >> >> base. >> >> >> >> * [MESOS-3538] - >> >> CgroupsNoHierarchyTest.ROOT_CGROUPS_NOHIERARCHY_MountUnmountHierarchy >> test >> >> is flaky. >> >> >> >> * [MESOS-3575] - V1 API java/python protos are not generated. >> >> >> >> >> >> ** Improvements >> >> >> >> * [MESOS-2719] - Deprecating '.json' extension in master endpoints >> urls. >> >> >> >> * [MESOS-2757] - Add -> operator for Option<T>, Try<T>, Result<T>, >> >> Future<T>. >> >> >> >> * [MESOS-2875] - Add containerId to ResourceUsage to enable QoS >> >> controller to target a container. >> >> >> >> * [MESOS-2964] - libprocess io does not support peek(). >> >> >> >> * [MESOS-2983] - Deprecating '.json' extension in slave endpoints >> url. >> >> >> >> * [MESOS-2984] - Deprecating '.json' extension in files endpoints >> url. >> >> >> >> * [MESOS-3037] - Add a SUPPRESS call to the scheduler. >> >> >> >> * [MESOS-3187] - Docker cli option support. >> >> >> >> * [MESOS-3304] - Remove remnants of LIBPROCESS_STATISTICS_WINDOW. >> >> >> >> * [MESOS-3312] - Factor out JSON to repeated protobuf conversion. >> >> >> >> * [MESOS-3340] - Command-line flags should take precedence over OS >> Env >> >> variables. >> >> >> >> * [MESOS-3347] - Remove dead code in src/linux/perf.cpp. >> >> >> >> * [MESOS-3377] - mesos docker container with container_name as ENV >> >> variable. >> >> >> >> * [MESOS-3457] - Add flag to disable hostname lookup. >> >> >> >> >> >> The full CHANGELOG for the release is available at: >> >> >> >> >> >> >> https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.25.0-rc2 >> >> >> >> >> >> >> -------------------------------------------------------------------------------- >> >> >> >> >> >> The candidate for Mesos 0.25.0 release is available at: >> >> >> >> >> >> >> https://dist.apache.org/repos/dist/dev/mesos/0.25.0-rc2/mesos-0.25.0.tar.gz >> >> >> >> >> >> The tag to be voted on is 0.25.0-rc2: >> >> >> >> >> https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.25.0-rc2 >> >> >> >> >> >> The MD5 checksum of the tarball can be found at: >> >> >> >> >> >> >> https://dist.apache.org/repos/dist/dev/mesos/0.25.0-rc2/mesos-0.25.0.tar.gz.md5 >> >> >> >> >> >> The signature of the tarball can be found at: >> >> >> >> >> >> >> https://dist.apache.org/repos/dist/dev/mesos/0.25.0-rc2/mesos-0.25.0.tar.gz.asc >> >> >> >> >> >> The PGP key used to sign the release is here: >> >> >> >> https://dist.apache.org/repos/dist/release/mesos/KEYS >> >> >> >> >> >> The JAR is up in Maven in a staging repository here: >> >> >> >> https://repository.apache.org/content/repositories/orgapachemesos-1078 >> >> >> >> >> >> Please vote on releasing this package as Apache Mesos 0.25.0! >> >> >> >> >> >> The vote is open until Thu Oct 8 2:30 AM PST 2015 (expediting to get >> out >> >> before MesosCon EU) and passes if a majority of at least 3 +1 PMC >> votes are >> >> cast. >> >> >> >> >> >> [ ] +1 Release this package as Apache Mesos 0.25.0 >> >> >> >> [ ] -1 Do not release this package because ... >> >> >> >> >> >> Thanks, >> >> >> >> Mpark, Joris and Niklas >> >> >> > >> > >> > >
