Done https://reviews.apache.org/r/39194/.
Folks, please take a look and let's have a couple of iterations over this. Cheers, Artem. On Fri, Oct 9, 2015 at 3:30 PM, Adam Bordelon <a...@mesosphere.io> wrote: > Artem: SGTM. Let's upstream it! > > On Fri, Oct 9, 2015 at 3:28 PM, Artem Harutyunyan <ar...@mesosphere.io> > wrote: > >> I am the maintainer of the >> https://github.com/mesosphere/mesos-website-container repo. I can just >> go ahead and post a review on Review Board and add the entire repo to >> ASF mesos (say under support/website). Once we do that we will retire >> mesosphere/mesos-website-container repo to avoid confusion. >> >> What do you think? >> >> Cheers, >> Artem. >> >> On Fri, Oct 9, 2015 at 2:33 PM, Jonathon Rossi <j...@jonorossi.com> wrote: >> > Adam, I wasn't aware of >> > https://github.com/mesosphere/mesos-website-container, no none of us >> tried >> > building the site in a docker container, but I'm happy to take a look at >> > that at some point soon. That repo doesn't have a LICENSE file, I'd be >> keen >> > to move the Dockerfile into the site directory of the mesos repo so it is >> > more discoverable and gets maintained as it is a pretty common use case, >> > thoughts? >> > >> > Marco, maybe I'm sticking my nose where it doesn't belong, but at the >> > beginning of the day both Dave and I independently wanted to work to >> > improve the documentation, and with Dave's shepherding we were able to do >> > much more than I expected. I don't think any of us expected the level of >> > feedback or the number of votes we got to be one of the winning teams. >> > >> > On Sat, Oct 10, 2015 at 6:48 AM, Marco Massenzio <ma...@mesosphere.io> >> > wrote: >> > >> >> For community's sake, it's clear now in hindsight that Dave did not do >> this >> >> because he cared at all about the site - all he was after was his >> personal >> >> glory and the material benefits of a brand new Apple Watch :D >> >> >> >> Congrats to the team that won the MesosCon Europe Hackathon: well >> deserved! >> >> >> >> *Marco Massenzio* >> >> >> >> *Distributed Systems Engineerhttp://codetrips.com <http://codetrips.com >> >* >> >> >> >> On Fri, Oct 9, 2015 at 7:33 PM, Adam Bordelon <a...@mesosphere.io> >> wrote: >> >> >> >> > +1 to allowing ReviewBoard/Github to manage website patches. >> >> > >> >> > It'll require fixing up >> >> > https://github.com/mesosphere/mesos-website-container to support the >> new >> >> > git-based model, but it should actually be simpler in the end. Dave, >> did >> >> > anybody try building the website in a Docker container like the >> >> > above-mentioned? I really don't want to install ruby/middleman/etc. >> on my >> >> > laptop. >> >> > >> >> > On Fri, Oct 9, 2015 at 10:50 AM, Kapil Arya <ka...@mesosphere.io> >> wrote: >> >> > >> >> > > +1 >> >> > > >> >> > > On Fri, Oct 9, 2015 at 1:02 PM, Niklas Nielsen < >> nik...@mesosphere.io> >> >> > > wrote: >> >> > > >> >> > > > +1 >> >> > > > >> >> > > > On 9 October 2015 at 09:50, Yan Xu <y...@jxu.me> wrote: >> >> > > > >> >> > > > > +1 for making it easier for contributors to understand the >> website >> >> > code >> >> > > > and >> >> > > > > collaboratively maintain it! >> >> > > > > >> >> > > > > -- >> >> > > > > Jiang Yan Xu <y...@jxu.me> @xujyan <http://twitter.com/xujyan> >> >> > > > > >> >> > > > > On Fri, Oct 9, 2015 at 5:21 PM, Paul Brett >> >> > <pbr...@twitter.com.invalid >> >> > > > >> >> > > > > wrote: >> >> > > > > >> >> > > > > > +1 >> >> > > > > > >> >> > > > > > On Fri, Oct 9, 2015 at 8:59 AM, haosdent <haosd...@gmail.com> >> >> > wrote: >> >> > > > > > >> >> > > > > > > +1! >> >> > > > > > > On Oct 9, 2015 10:37 PM, "Kevin Sweeney" < >> kevi...@apache.org> >> >> > > wrote: >> >> > > > > > > >> >> > > > > > > > +1! >> >> > > > > > > > >> >> > > > > > > > On Fri, Oct 9, 2015 at 3:35 PM Marco Massenzio < >> >> > > > ma...@mesosphere.io> >> >> > > > > > > > wrote: >> >> > > > > > > > >> >> > > > > > > > > +1 >> >> > > > > > > > > >> >> > > > > > > > > Dave - great stuff! >> >> > > > > > > > > >> >> > > > > > > > > *Marco Massenzio* >> >> > > > > > > > > >> >> > > > > > > > > *Distributed Systems Engineerhttp://codetrips.com < >> >> > > > > > > http://codetrips.com >> >> > > > > > > > >* >> >> > > > > > > > > >> >> > > > > > > > > On Fri, Oct 9, 2015 at 3:05 PM, Dave Lester < >> >> > > d...@davelester.org >> >> > > > > >> >> > > > > > > wrote: >> >> > > > > > > > > >> >> > > > > > > > > > As part of the #MesosCon Europe hackathon, my team has >> >> been >> >> > > > > making >> >> > > > > > > > > > improvements to the website. Among these changes, we'd >> >> like >> >> > > to >> >> > > > > > > propose >> >> > > > > > > > > > changing where the website source files live by moving >> >> them >> >> > > to >> >> > > > > the >> >> > > > > > > main >> >> > > > > > > > > > Mesos codebase. Our current progress / working branch >> of >> >> > this >> >> > > > is >> >> > > > > > > > > > available on GitHub: >> >> > > > > > https://github.com/fayusohenson/mesos/tree/site >> >> > > > > > > > > > >> >> > > > > > > > > > * What does this mean? * >> >> > > > > > > > > > We've added a /site directory to the Mesos codebase, >> >> which >> >> > > > > includes >> >> > > > > > > the >> >> > > > > > > > > > website source files. Today, these live in subversion. >> >> The >> >> > > rake >> >> > > > > > file >> >> > > > > > > > and >> >> > > > > > > > > > other parts of building the website all work in this >> new >> >> > > > > > environment, >> >> > > > > > > > > > plus a number of related fixes (image linking, etc). >> >> > > > > > > > > > >> >> > > > > > > > > > For committers that are familiar with the current >> model >> >> for >> >> > > > > pushing >> >> > > > > > > the >> >> > > > > > > > > > site live, this immediate change still requires us >> `svn >> >> > > commit` >> >> > > > > the >> >> > > > > > > > > > /publish directory for the website (static files that >> are >> >> > > > > > generated). >> >> > > > > > > > > > >> >> > > > > > > > > > * Why this change? * >> >> > > > > > > > > > 1. Today we do not have an easy process for the >> community >> >> > to >> >> > > > > > > contribute >> >> > > > > > > > > > to the project website. By merging this with the Mesos >> >> > > > codebase, >> >> > > > > it >> >> > > > > > > > will >> >> > > > > > > > > > be significantly easier to send a review or pull >> request. >> >> > > > > > > > > > 2. It'll be easier for committers to manage the >> website, >> >> > and >> >> > > > > check >> >> > > > > > > that >> >> > > > > > > > > > documentation changes render on the website properly >> >> before >> >> > > > > > > committing. >> >> > > > > > > > > > Because it's difficult to do today, this is often not >> >> > > checked. >> >> > > > :( >> >> > > > > > > > > > 3. It's a solid step toward an automated deployment of >> >> the >> >> > > > > website >> >> > > > > > in >> >> > > > > > > > > > the future: >> >> > https://issues.apache.org/jira/browse/MESOS-1309 >> >> > > > > > > > > > >> >> > > > > > > > > > * Who approves of this change? * >> >> > > > > > > > > > As the Mesos website maintainer, I feel good about >> this >> >> > > change >> >> > > > > and >> >> > > > > > > its >> >> > > > > > > > > > direction for the project. Before committing this >> change, >> >> > I'd >> >> > > > > like >> >> > > > > > > > > > community support that including this in the main >> Mesos >> >> > > > codebase >> >> > > > > > > makes >> >> > > > > > > > > > sense. >> >> > > > > > > > > > >> >> > > > > > > > > > Comments? Questions? >> >> > > > > > > > > > >> >> > > > > > > > > > Dave >> >> > > > > > > > > > >> >> > > > > > > > > >> >> > > > > > > > >> >> > > > > > > >> >> > > > > > >> >> > > > > > >> >> > > > > > >> >> > > > > > -- >> >> > > > > > @paul_b >> >> > > > > > >> >> > > > > >> >> > > > >> >> > > >> >> > >> >> >> > >> > >> > >> > -- >> > Jono >>