I think having recently been through the libprocess “continuations” and callbacks, we do lack a pattern that logs errors that have full context. For example, we don’t have a pattern of logging at “onFailed’/“onDiscarded” sites at each layer of the call stack. What this leads to is a top level error message at feature layer that has context about a low level IO layer. This gets even harder to decipher when there are compositions of “continuations”. It would have helped if each layer added to the error context.
-Jojy > On Nov 6, 2015, at 12:54 PM, Neil Conway <[email protected]> wrote: > > On Fri, Nov 6, 2015 at 12:44 PM, Marco Massenzio <[email protected]> wrote: >> I may be wrong here, but adding (filename, line_nr) to the Error() object >> is performance-impact and may need to be disabled in Production >> environments > > I don't think that will be the case: passing __FILE__ and __LINE__ > just means passing two additional (constant-valued) parameters to a > function call, so the performance impact should be very modest. > > Neil
