I also like to apply reviews, specially when reviewbot hasn't got to that review yet. My guess is that apply-reviews is also used when people are asking for new features progress or bug fixes that haven't been merged yet.
On Thu, Nov 12, 2015 at 11:42 AM, Alex Clemmer <clemmer.alexan...@gmail.com> wrote: > Just a data point, I always apply reviews, not only to compile, but > also just because I like using my existing toolset to interact with > the code and understand it. > > On Thu, Nov 12, 2015 at 12:59 AM, Artem Harutyunyan <ar...@mesosphere.io> > wrote: > > Interesting, I always thought that people apply, compile and try out > > patches locally before giving them a 'Ship It'. > > > > Regarding pushing the code, I don't have enough of context, so could you > > please create a JIRA if you still think that it'd be great to have that > > feature added to the script? > > > > On Wed, Nov 11, 2015 at 6:18 PM, Vinod Kone <vinodk...@gmail.com> wrote: > > > >> AFAIK, apply-reviews is used mainly by committers. Maybe some one can > use > >> to locally test a review chain of somebody else, but that is pretty > rare. > >> > >> Regarding having apply-reviews to automatically push commits to the > repo, > >> we need to figure out the credentials delegation aspect. Ideally, it > would > >> be run by CI. > >> > >> On Tue, Nov 10, 2015 at 11:10 PM, Jonathon Rossi <j...@jonorossi.com> > >> wrote: > >> > >> > We've also still got this one open that I intended would take us right > >> > through to the automatic site build: > >> > > >> > https://issues.apache.org/jira/browse/MESOS-3687 > >> > > >> > On Wed, Nov 11, 2015 at 5:00 PM, Artem Harutyunyan < > ar...@mesosphere.io> > >> > wrote: > >> > > >> > > Hey Vinod, > >> > > > >> > > Here is the JIRA https://issues.apache.org/jira/browse/MESOS-3883. > >> > > > >> > > I don't mean to hijack this thread, and I apologize for the > off-topic, > >> > but > >> > > do you think it would make sense to have another script for > committers > >> > that > >> > > will use apply-reviews.py? At some point you also mentioned that it > >> would > >> > > be good to have apply-reviews.py do the actual commits but we did > not > >> > > pursue the idea because it was not a relevant feature for most of > the > >> > > folks. > >> > > > >> > > Cheers, > >> > > Artem. > >> > > > >> > > > >> > > On Tue, Nov 10, 2015 at 7:30 PM, Vinod Kone <vinodk...@gmail.com> > >> wrote: > >> > > > >> > > > That said, this can be automated as a step in apply-reviews > script. > >> For > >> > > > example, the script can check if something in site/ (or docs/ ?) > is > >> > being > >> > > > committed and if yes, also do an svn update. @artem do you want to > >> take > >> > > > this on as you revamp the apply-reviews script? > >> > > > > >> > > > On Tue, Nov 10, 2015 at 1:23 AM, Adam Bordelon < > a...@mesosphere.io> > >> > > wrote: > >> > > > > >> > > > > Since it's still a manual process, the website is usually only > >> > updated > >> > > a) > >> > > > > when we have a new release to announce, or b) when some other > >> > > blog-worthy > >> > > > > content arises (e.g. MesosCon). > >> > > > > > >> > > > > On Tue, Nov 10, 2015 at 1:06 AM, Jonathon Rossi < > >> j...@jonorossi.com> > >> > > > > wrote: > >> > > > > > >> > > > > > It is currently a manual process performed by a committer, > >> however > >> > > > there > >> > > > > > are plans to make it automated. See this thread for the recent > >> > > > > discussion: > >> > > > > > > >> > > > > > > http://www.mail-archive.com/dev@mesos.apache.org/msg33541.html > >> > > > > > > >> > > > > > On Tue, Nov 10, 2015 at 6:56 PM, Neil Conway < > >> > neil.con...@gmail.com> > >> > > > > > wrote: > >> > > > > > > >> > > > > > > Does anyone know how frequently the docs at > mesos.apache.org > >> are > >> > > > > > > updated? I notice that some docs changes from > 1 week ago > >> aren't > >> > > > > > > reflected on the current site. > >> > > > > > > > >> > > > > > > Neil > >> > > > > > > > >> > > > > > > >> > > > > > -- > >> > > > > > Jono > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > > >> > > >> > -- > >> > Jono > >> > > >> > > > > -- > Alex > > Theory is the first term in the Taylor series of practice. -- Thomas M > Cover (1992) >
