Hi Tim, What are the backwards compatibility implications of this?
> On Jan 6, 2016, at 6:50 PM, tnac...@apache.org wrote: > > Repository: mesos > Updated Branches: > refs/heads/master c258d8af7 -> 52abf8de3 > > > Fixed posix filesystem isolator to not allow executors with image. > > Review: https://reviews.apache.org/r/41909/ > > > Project: http://git-wip-us.apache.org/repos/asf/mesos/repo > Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/52abf8de > Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/52abf8de > Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/52abf8de > > Branch: refs/heads/master > Commit: 52abf8de380cf7a3c3d8a2e5616b3d34d7b6b277 > Parents: c258d8a > Author: Timothy Chen <tnac...@apache.org> > Authored: Tue Jan 5 17:29:57 2016 -0800 > Committer: Timothy Chen <tnac...@apache.org> > Committed: Wed Jan 6 18:01:32 2016 -0800 > > ---------------------------------------------------------------------- > .../containerizer/mesos/isolators/filesystem/posix.cpp | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > ---------------------------------------------------------------------- > > > http://git-wip-us.apache.org/repos/asf/mesos/blob/52abf8de/src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > ---------------------------------------------------------------------- > diff --git a/src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > b/src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > index 00ff84b..4d6100e 100644 > --- a/src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > +++ b/src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > @@ -78,17 +78,18 @@ Future<Option<ContainerPrepareInfo>> > PosixFilesystemIsolatorProcess::prepare( > return Failure("Container has already been prepared"); > } > > - // Return failure if the container change the filesystem root > - // because the symlinks will become invalid in the new root. > if (executorInfo.has_container()) { > CHECK_EQ(executorInfo.container().type(), ContainerInfo::MESOS); > > + // Return failure if the container change the filesystem root > + // because the symlinks will become invalid in the new root. > if (executorInfo.container().mesos().has_image()) { > return Failure("Container root filesystems not supported"); > } > > - // TODO(jieyu): Also return a failure if there exists images in > - // the specified volumes. > + if (executorInfo.container().volumes().size() > 0) { > + return Failure("Volumes in ContainerInfo is not supported"); > + } > } > > infos.put(containerId, Owned<Info>(new Info(directory))); >
