Github user vinodkone commented on a diff in the pull request:
https://github.com/apache/mesos/pull/93#discussion_r58094904
--- Diff: 3rdparty/Makefile.am ---
@@ -51,7 +51,7 @@ EXTRA_DIST = \
EXTRA_DIST += \
$(LEVELDB).patch
-# We need to patch ZooKeeper in order to get 3.4.5 to compile on
+# We need to patch ZooKeeper in order to get 3.4.8 to compile on
# OS X 10.10. See: MESOS-1797.
--- End diff --
Does this comment still apply? AFAICT MESOS-1797 doesn't apply to ZK 3.4.8
since that issue has been resolved in ZK 3.4.7. Looks all the patch does is
apply PPC specific fixes for which you already submitted a review
https://reviews.apache.org/r/45376/.
I would recommend to kill the zookeper.patch stuff in this review
altogether since 3.4.8 doesn't need any patches per se. Then in
https://reviews.apache.org/r/45376/ you can add back the patch stuff and
mention that you need the patch to compile it on PPC.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
