Sounds good: https://reviews.apache.org/r/57422/
Neil
On Mon, Mar 6, 2017 at 8:53 PM, Zameer Manji <zma...@apache.org> wrote:
> The TODO made me think that the time information here could be timezone
> dependent in some cases.
>
> If it's intended to always represent the time since the Unix epoch then TZ
> info is not useful.
>
> I think that comment should be removed for clarity.
>
> On Mon, Mar 6, 2017 at 8:38 PM, Neil Conway <neil.con...@gmail.com> wrote:
>
>> I always found that TODO confusing. If a `TimeInfo` is intended to
>> represent the amount of time that has elapsed since the (Unix) epoch,
>> I would expect it to be timezone independent. Can you clarify why
>> having TZ info would be useful?
>>
>> Neil
>>
>> On Mon, Mar 6, 2017 at 7:51 PM, Zameer Manji <zma...@apache.org> wrote:
>> > Hey,
>> >
>> > I noticed there is a TODO on the TimeInfo for adding Time Zone
>> information.
>> > ```
>> > /**
>> > * Represents time since the epoch, in nanoseconds.
>> > */
>> > message TimeInfo {
>> > required int64 nanoseconds = 1;
>> >
>> > // TODO(josephw): Add time zone information, if necessary.
>> > }
>> > ```
>> >
>> > Since there is no TZ information attached the timestamp, should
>> frameworks
>> > assume that the Mesos Master system TZ is the same as the framework TZ?
>> > That is what I'm thinking of doing, but I'm not sure what was the
>> intention
>> > of the authors of the API.
>> >
>> > Also, would it be possible to attach TZ information? It would make
>> > understanding the TimeInfo much easier when it is received by the
>> framework.
>> >
>> > --
>> > Zameer Manji
>>
>> --
>> Zameer Manji
>>
