Github user jpeach commented on a diff in the pull request:
https://github.com/apache/mesos/pull/248#discussion_r148844153
--- Diff: src/master/validation.cpp ---
@@ -350,12 +353,13 @@ Option<Error> reregisterSlave(
}
if (executor.has_executor_id()) {
- if (executorIDs.contains(executor.executor_id())) {
+ IDPair idpair = IDPair(executor.framework_id(),
executor.executor_id());
+ if (executorIDs.contains(idpair)) {
return Error("Executor has a duplicate ExecutorID '" +
stringify(executor.executor_id()) + "'");
--- End diff --
We should update this error message:
```
Error("Framework '" + executor.framework_id() +
'" has a duplicate ExecutorID '" +
stringify(executor.executor_id()) + "'");
```
---
