Github user qianzhangxa commented on a diff in the pull request:

    https://github.com/apache/mesos/pull/299#discussion_r197723026
  
    --- Diff: src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ---
    @@ -428,6 +428,10 @@ Future<Nothing> NetworkCniIsolatorProcess::recover(
           }
         }
     
    +    if (infos.contains(containerId)) {
    --- End diff --
    
    This will make the unknown orphaned containers are skipped (i.e., we will 
miss to do cleanup for unknown orphaned container). So I would suggest to just 
do a `continue;` between L420 and L421.
    
    @vixns Do you want to post a patch in https://reviews.apache.org/? 


---

Reply via email to