Thanks Andy! Responses inlined below.
> No: As the only character we've run into a problem with is `:` > (MESOS-9109), it might not be worth it to generalize this to solve a bunch > of problems that we haven't encountered. > > It's true that I'm not aware of other scenarios where filesystem-disallowed characters in task/executor IDs have caused issues for users, and this issue has existed for a long time. However, when feasible I would like to fix issues that we're aware of before they cause problems for users, rather than after. I would suggest that since we have one compelling case that we need to address now, it's worth formulating an approach for the general case, so that we can be sure any current work doesn't get in our way later on. > I'm somewhat comfortable doing so only for Windows, as we don't really > need to worry about the recovery scenario; but very uncomfortable about > doing so for Linux etc., for precisely that reason. > > So expanding this is definitely up for debate; but we must fix the bug > with `:`. > > Indeed, addressing the general case may prove to be much more complex - I can certainly identify with this situation, where a fix for a smaller issue turns into a big project :) It may turn out to be possible to implement a scoped-down solution for the colon case now, and extend it later on. I think it would be good if we could at least get an idea of how we want to handle the general case now, so that any short-term solutions can be a constructive step toward the long-term. Cheers, G
