Dmitrii— here we go: MESOS-9499 [1]. I've noticed you don't have an Apache JIRA account, I'd suggest you create one so that you can assign the ticket to you and hence get credit properly. Hope it is not your last contribution to Apache projects : ).
[1] https://issues.apache.org/jira/browse/MESOS-9499 On Thu, Dec 20, 2018 at 6:40 PM Kishchukov, Dmitrii (NIH/NLM/NCBI) [C] < dmitrii.kishchu...@nih.gov> wrote: > The patch turned out to be quite simple. I Changed only Authentication and > URL classes. > > Should I create a Jira ticket for this or someone will create it for me? > > > -- > > Dmitrii Kishchukov. > Leading software developer > Submission Portal Team > > > On 12/10/18, 3:01 PM, "Joseph Wu" <jos...@mesosphere.io> wrote: > > There are two options for contributing: > 1) You can make a pull request against the GitHub mirror: > https://github.com/apache/mesos . We generally only use PRs for minor > changes, like typos, documentation, or uploading binaries. See > http://mesos.apache.org/documentation/latest/beginner-contribution/ > 2) For larger changes, or more involved/impactful changes, we prefer > https://reviews.apache.org/ instead. See > http://mesos.apache.org/documentation/latest/advanced-contribution/ > > I suspect this ZK Auth feature will be a fairly significant change, so > I > recommend option (2). > > On Mon, Dec 10, 2018 at 11:47 AM Kishchukov, Dmitrii (NIH/NLM/NCBI) > [C] < > dmitrii.kishchu...@nih.gov> wrote: > > > I have a working version. How should I make the patch? A branch in > the git > > repository? Do I need to get permissions? > > > > -- > > > > Dmitrii Kishchukov. > > Leading software developer > > Submission Portal Team > > > > > > On 12/6/18, 12:56 PM, "Vinod Kone" <vinodk...@apache.org> wrote: > > > > Dmitrii. > > > > That approach sounds reasonable. Would you like to work on this? > Are > > you > > looking for a reviewer/shepherd? > > > > On Thu, Dec 6, 2018 at 11:28 AM Kishchukov, Dmitrii > (NIH/NLM/NCBI) [C] > > < > > dmitrii.kishchu...@nih.gov> wrote: > > > > > Mesos allow using only digest authentication scheme for > Zookeeper. > > Which > > > is bad because Zookeeper has quite a flexible security model. > > > It is easy to make you own authenticator with its own scheme > name. > > > > > > To support fully Zookeeper authentication, Mesos has pass two > items > > into > > > Zookeeper: > > > scheme and credentials. > > > credentials can have different format depending on > authentication > > scheme. > > > For digest scheme it is ‘login:password’ > > > > > > All Mesos should do just pass scheme and credentials to > Zookeeper. > > > > > > Another improvement might be be to configure credentials via > file > > instead > > > of URI > > > > > > For example it can be two command line options: > > > --zk_auth_scheme and –zk_auth_credentials > > > > > > It can be used like this: > > > --zk_auth_scheme=some_custome_scheme > –zk_auth_credentials=filename > > > > > > --zk_auth_credentials can just get all contents of the file as > > credentials > > > string. > > > > > > Class Authentication in Mesos already contains all that we > need. The > > > problem is what Mesos pass to the constructor. > > > > > > > > > -- > > > > > > Dmitrii Kishchukov. > > > > > > > > > > > > > > >
