Another thing to keep in mind is that we are very close to release 1.8.0. Is this glog upgrade potentially risky? If yes, maybe we should wait until 1.8 is branched off and then do it on master / 1.9 .
On Wed, Mar 27, 2019 at 10:00 AM Benjamin Mahler <[email protected]> wrote: > Thanks Andrei! > > Some interesting changes for us from what I see: > - Looks like there are some potential memory allocation reduction changes > which is nice. ("reduce dynamic allocation from 3 to 1 per log message" in > 0.3.4) > - https://github.com/google/glog/pull/245 (this will change the log file > names for those that see 'invalid-user' in the filenames, which I recall > seeing often) > - https://github.com/google/glog/pull/145 (this fixes the issue we filed > https://github.com/google/glog/issues/84 where we've had to disable > GLOG_drop_log_memory). > > After this update we should be able to remove our special case disablement > of GLOG_drop_log_memory: > > https://github.com/apache/mesos/blob/1.7.2/src/logging/logging.cpp#L184-L194 > > Is there a ticket for the glog upgrade to 0.4.0? I filed > https://issues.apache.org/jira/browse/MESOS-9680 but couldn't find the > 0.4.0 ticket to link that it's blocked by the upgrade. > > On Tue, Mar 26, 2019 at 9:17 AM Andrei Sekretenko < > [email protected]> wrote: > > > Hi all, > > We are intending to update the bundled glog from 0.3.3 to 0.4.0. > > > > If you have any objections/concerns, or know about any issues introduced > > into glog between 0.3.3 and 0.4.0, please raise them. > > > > Corresponding glog changelogs: > > https://github.com/google/glog/releases/tag/v0.4.0 > > https://github.com/google/glog/releases/tag/v0.3.5 > > https://github.com/google/glog/releases/tag/v0.3.4 > > > > Regards, > > Andrei Sekretenko > > >
