[ 
https://issues.apache.org/jira/browse/METAMODEL-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14729055#comment-14729055
 ] 

ASF GitHub Bot commented on METAMODEL-172:
------------------------------------------

GitHub user LosD opened a pull request:

    https://github.com/apache/metamodel/pull/48

    Use missing and exists filters for null comparisons.

    This will make isNull() and isNotNull() work. They failed before, as a term 
query, which does not support null values, was used. A test was also 
un-ignored; It was ignored as it used to fail, but the fix  for METAMODEL-172 
fixed the test as well.
    
    Fixes METAMODEL-184

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/LosD/metamodel master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metamodel/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #48
    
----
commit 053c34684f6f46948bc3ad3a71a5a366ac9526f8
Author: Dennis Du Krøger <[email protected]>
Date:   2015-09-03T13:41:44Z

    Use missing and exists filters for null comparisons.
    
    This will make isNull() and isNotNull() work. They failed before, as a
     term query, which does not support null values, was used. A test was
      also un-ignored; It was ignored as it used to fail, but the fix
      for METAMODEL-172 fixed the test as well.

----


> ElasticSearch Date types should be converted properly
> -----------------------------------------------------
>
>                 Key: METAMODEL-172
>                 URL: https://issues.apache.org/jira/browse/METAMODEL-172
>             Project: Apache MetaModel
>          Issue Type: Bug
>            Reporter: Alberto
>            Assignee: Alberto
>            Priority: Critical
>
> When working with ElasticSearch indexes that contains Date types the API is 
> returning Strings instead of proper Date object.
> We should add some logic inside the ElasticSearchUtils createRow() method to 
> convert these strings to java.Date objects. As we are not doing this 
> conversion so far the TimeComparator convertFromString method is not able to 
> parse the string value as a Date, the method returns null and then the 
> FormatHelper class is throwing an IllegalStateException.
> This is a bit tricky though because the number of date formats supported by 
> ElasticSearch is quite big  to think about creating a SimpleDateFormat to 
> support every single case: 
> https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-date-format.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to