[
https://issues.apache.org/jira/browse/METAMODEL-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945801#comment-14945801
]
ASF GitHub Bot commented on METAMODEL-187:
------------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/49
> ExcelDataContext uses more memory than it needs to for File-based resources.
> ----------------------------------------------------------------------------
>
> Key: METAMODEL-187
> URL: https://issues.apache.org/jira/browse/METAMODEL-187
> Project: Apache MetaModel
> Issue Type: Bug
> Reporter: Dennis Du Krøger
> Assignee: Kasper Sørensen
> Priority: Minor
> Fix For: 4.4.0
>
> Attachments: Memory use File-based.png, Memory use
> InputStream-based.png
>
>
> ExcelDataContext uses the input stream from resources, even if it is a
> FileResource. This is pretty wasteful memory-wise, both according to
> http://poi.apache.org/spreadsheet/quick-guide.html#FileInputStream and to own
> tests; I made a naïve change that uses the internal File of FileResources on
> a huge file. With InputStream, getting the defaultSchema used around 950 MB
> in average, while it used around 650 in average with the File based version
> (nothing scientific, just eyeballed in JVisualVM).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
