Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/57#discussion_r41487798
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java
---
@@ -336,6 +336,13 @@ public DataSet executeQuery(CompiledQuery
compiledQuery, Object... values) {
private DataSet execute(Connection connection, Query query, Statement
statement, JdbcCompiledQuery compiledQuery,
JdbcCompiledQueryLease lease, Object[] values) throws
SQLException, MetaModelException {
+ Integer maxRows = query.getMaxRows();
+
+ final List<SelectItem> selectItems =
query.getSelectClause().getItems();
+ if (maxRows != null && maxRows.intValue() == 0) {
--- End diff --
While that is true, I really don't hope anyone would go "Oh, I'll remove
that" without at least thinking about why that would be there.
Anyway, it's not really an issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
