Github user kaspersorensen commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/68#discussion_r43602188
  
    --- Diff: 
full/src/test/java/org/apache/metamodel/ExcelDataContextFactoryTest.java ---
    @@ -23,9 +23,7 @@
     import org.apache.metamodel.excel.ExcelConfiguration;
     import org.apache.metamodel.excel.ExcelDataContext;
     
    -import junit.framework.TestCase;
    -
    -public class DataContextFactoryTest extends TestCase {
    +public class ExcelDataContextFactoryTest extends  MongoDbTestCase{
    --- End diff --
    
    I know this class currently seems to only test the excel scenario, but it 
is a test of ```DataContextFactory``` so I find it more natural to name it like 
that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to