> On Nov. 10, 2015, 8:22 a.m., Kasper Sørensen wrote: > > Looks good to me!
Hi Kasper, I am unable to commit as I don't have privilages to commit to metamodel project for my username, could you please help me resolve the issue. - Sai Krishna Kishore ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40074/#review105809 ----------------------------------------------------------- On Nov. 9, 2015, 11:15 p.m., Sai Krishna Kishore Beathanabhotla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40074/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2015, 11:15 p.m.) > > > Review request for MetaModel. > > > Repository: metamodel > > > Description > ------- > > Added validation to check for invalid characters and sheetname length for > excel > > > Diffs > ----- > > excel/src/main/java/org/apache/metamodel/excel/ExcelUpdateCallback.java > f99ec89 > excel/src/test/java/org/apache/metamodel/excel/ExcelUpdateCallbackTest.java > 97101bd > > Diff: https://reviews.apache.org/r/40074/diff/ > > > Testing > ------- > > 1) Added test cases for the same. > 2) Verified with name greater than 31 characters. > 3) Verified name with invalid characters like [ ] : \ / ? * > > > Thanks, > > Sai Krishna Kishore Beathanabhotla > >
