Github user ashwinrayaprolu1984 commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/72#discussion_r45000717
--- Diff: core/src/main/java/org/apache/metamodel/query/QueryConstants.java
---
@@ -0,0 +1,41 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.metamodel.query;
+
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * This class shall hold all constant configurable variables related to
Query
+ * parsing
+ *
+ * @author ashwinrayaprolu
+ *
+ */
+public final class QueryConstants {
+ /**
+ * This field will hold start and end character for delimiter that
+ * can be used
+ */
+ public static final Map<Character, Character> delimiterMap = new
HashMap<Character, Character>();
--- End diff --
OK i can remove that class. I thought externalizing those delimiters.. Let
me know if you are ok with me keeping the same logic in
FormItemParser.parseTableItem(String itemToken) method. Or do you have any
better solution? FYI: Deleted CSVDirectory related code.. Working on it
locally. will commit once all my changes are done tested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
