Github user albertostratio commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/70#discussion_r47059516
--- Diff: core/src/main/java/org/apache/metamodel/query/SelectItem.java ---
@@ -152,7 +166,24 @@ public SelectItem(Column column, FromItem fromItem) {
* @param fromItem
*/
public SelectItem(FunctionType function, Column column, FromItem
fromItem) {
- this(column, fromItem, function, null, null, null, false);
+ this(column, fromItem, function, null, null, null, null, false);
--- End diff --
Would it make more sense to put the if before the creation of the object? I
mean if the column is null and we're throwing an exception, why are we
instantiating the object?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
