[ 
https://issues.apache.org/jira/browse/METAMODEL-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048604#comment-15048604
 ] 

ASF GitHub Bot commented on METAMODEL-218:
------------------------------------------

Github user drexler42 commented on the pull request:

    https://github.com/apache/metamodel/pull/76#issuecomment-163211807
  
    I can copy the customers table directly into Postgres now. The fix works. A 
word of warning though:
    - MetaModel 4.4.2-SNAPSHOT is not compatible with DataCleaner master.
    -- Package names of ElasticSearch datastore is changed in MM, and must be 
changed accordingly in DC.
    -- The new MM neo4j module introduces a tattletale clash on an json library.
    
    I excluded the culprit from DC, but then the API module does not compile 
anymore. I gave up on solving that at that point.
    ```
                        <dependency>
                                <groupId>org.apache.metamodel</groupId>
                                <artifactId>MetaModel-full</artifactId>
                                <exclusions>
                                        <exclusion>
                                                <artifactId>json</artifactId>
                                                
<groupId>org.apache.geronimo.bundles</groupId>
                                        </exclusion>
                                </exclusions>
                        </dependency>
    ```
    
    The fix in itself is fine. So I'll merge it.


> Mapping of STRING and NUMBER data types in JDBC module's CREATE TABLE support 
> not working
> -----------------------------------------------------------------------------------------
>
>                 Key: METAMODEL-218
>                 URL: https://issues.apache.org/jira/browse/METAMODEL-218
>             Project: Apache MetaModel
>          Issue Type: Bug
>    Affects Versions: 4.4.1
>            Reporter: Kasper Sørensen
>            Assignee: Kasper Sørensen
>
> It seems that the work we did in METAMODEL-141 had a few omissions. 
> Specifically the NUMBER and STRING data type support in the JDBC module isn't 
> correctly being applied.
> The issue seems to be a missing return statement(!) ...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to